use upstream rustup init script download workaround for old curl version on CentOS6 #7619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicexplorer
force-pushed
the
try-rustup-init-fix
branch
from
8c74219
to
6e5b819
Compare
cosmicexplorer
changed the title
cosmicexplorer
requested review from
jsirois,
Eric-Arellano,
illicitonion,
ity and
stuhood
|
This is now ready for review! |
Eric-Arellano
approved these changes
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #7615, where we had to work around a sudden error downloading rustup on our CentOS6 docker image bootstrap shards. A workaround was made available from rustup via rust-lang/rustup#1803, so we can remove our own workaround.
Solution
bootstrap_rust.sh.rustup-initscript to a temporary file.Result
Our bootstrap shards should continue working!